[FEATURE] campaign participation id in ke snapshots [Pix-15753] #10844
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
alicegoarnisson
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
alicegoarnisson
force-pushed
the
pix-15753/campaign-participation-id-in-ke-snapshots
branch
from
851b627 to
6dcb3f7
Compare
xav-car
reviewed
Dec 18, 2024
Comment on lines
+6
to
+8
| table.integer(COLUMN_NAME).unsigned().nullable(); | ||
|
|
||
| table.foreign(COLUMN_NAME).references('id').inTable('campaign-participations'); |
There was a problem hiding this comment.
suggestion
On pourrait tout faire en une ligne, peut s'inspirer de 20241118134739_create-organizations-profile-rewards-table.js
xav-car
reviewed
Dec 18, 2024
| @@ -18,13 +18,14 @@ function _toKnowledgeElementCollection({ snapshot } = {}) { | |||
| ); | |||
| } | |||
|
|
|||
| const save = async function ({ userId, snappedAt, knowledgeElements }) { | |||
| const save = async function ({ userId, snappedAt, knowledgeElements, campaignParticipationId }) { | |||
There was a problem hiding this comment.
todo modifier le builder, databasebuilder.factory.Ke-snapshots
Certainement les seeds à mettre à jour pour être ISO avec le futur
xav-car
approved these changes
Dec 18, 2024
xav-car
added
Development in progress
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Dans le cadre de l'anonymisation, on veut pouvoir rattacher les enregistrements de la table knowledge-element-snapshots aux campaign participations qui leur correspondent.
🎁 Proposition
Pour cela, on ajoute une colonne campaign participation id à la table ke snapshots. On enregistre également le campaign participation id au moment de l'insertion d'un snapshot en base de données.
🎅 Pour tester
On fait un parcours sur le PixApp de la RA et on partage ses résultats.
Puis on se connecte au scalingo de la RA. On vérifie que la table ke-snapshots a bien la colonne "campaignParticipationId" remplie pour notre utilisateur.